Skip to content

Add icons for group/role and notification subject types in permissions table #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add icons for group/role and notification subject types in permissions table #2942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22a6e07
Initial plan
Copilot Mar 17, 2026
06de250
feat: add icons for group/role and notification subject types in perm…
Copilot Mar 17, 2026
e65c7f8
revert unrelated package-lock.json changes
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/Permissions/PermissionsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import PlaybookSpecIcon from "../Playbooks/Settings/PlaybookSpecIcon";
import { TopologyLink } from "../Topology/TopologyLink";
import { permissionObjectList } from "./ManagePermissions/Forms/FormikPermissionSelectResourceFields";
import { permissionsActionsList } from "./PermissionsView";
import { BsBan } from "react-icons/bs";
import { BsBan, BsBell } from "react-icons/bs";
import { UserGroupIcon } from "@heroicons/react/solid";
import { Link } from "react-router-dom";
import CRDSource from "../Settings/CRDSource";
import { PermissionErrorDisplay } from "./PermissionErrorDisplay";
Expand Down Expand Up @@ -39,6 +40,7 @@ const permissionsTableColumns: MRT_ColumnDef<PermissionsSummary>[] = [
const groupName = group.name || subject;
return (
<div className="flex flex-row items-center gap-2">
<UserGroupIcon className="h-5 w-5 text-gray-600" />
<span className="truncate font-mono text-sm" title={groupName}>
{group.name ? "Group: " : "Role: "}
{groupName}
Expand Down Expand Up @@ -69,6 +71,7 @@ const permissionsTableColumns: MRT_ColumnDef<PermissionsSummary>[] = [
if (notification) {
return (
<div className="flex flex-row items-center gap-2">
<BsBell className="h-5 w-5 text-gray-600" />
<span>
<Link
className="link"
Expand Down
Loading