Skip to content

Fix runtime crash when server returns undefined roles in auth context #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix runtime crash when server returns undefined roles in auth context #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee94247
Initial plan
Copilot Mar 31, 2026
ded5422
fix: handle undefined roles and payload in auth context to prevent st…
Copilot Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/components/Authentication/Kratos/KratosAuthContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ export default function KratosAuthContextProvider({ children }: Props) {
return <ErrorPage error={error} />;
}

if (!payload) {
return <FullPageSkeletonLoader />;
}

return (
<AuthContext.Provider
value={{
Expand Down
2 changes: 1 addition & 1 deletion src/context/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function createAuthorizer(ctx: WhoamiResponse["payload"]): Authorizer {
const authorizer = new casbinAuthorizer("manual");
const builtPerms: Record<string, any> = {};

ctx.roles.forEach((role) => {
(ctx.roles ?? []).forEach((role) => {
const permissions = permDefs[role as keyof typeof permDefs] ?? {};
Object.entries(permissions).forEach(([key, value]) => {
builtPerms[key] = [...(builtPerms[key] || []), ...value];
Expand Down
Loading