Skip to content

Fix MetaMask success error handling #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2bf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MetaMask success error handling #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 60 additions & 5 deletions app/(app)/(configure)/summary/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,52 @@ const RPC_FLASHBOTS_NET = 'https://rpc.flashbots.net';
const ETH_CHAIN_ID = '0x1';
const ETH_CHAIN_NAME = 'Ethereum Mainnet';

const getWalletErrorMessage = (error: unknown) => {
if (error instanceof Error) {
return error.message;
}

if (typeof error === 'string') {
return error;
}

if (
error &&
typeof error === 'object' &&
'message' in error &&
typeof error.message === 'string'
) {
return error.message;
}

return '';
};

const getWalletErrorCode = (error: unknown) => {
if (
error &&
typeof error === 'object' &&
'code' in error &&
(typeof error.code === 'number' || typeof error.code === 'string')
) {
const code = Number(error.code);
return Number.isNaN(code) ? undefined : code;
}

return undefined;
};

const isSuccessfulMetaMaskAddError = (error: unknown) => {
const code = getWalletErrorCode(error);
const message = getWalletErrorMessage(error).toLowerCase();

return (
message.includes('is not a function') ||
(code === -32602 &&
message.includes('may not specify default metamask chain'))
);
};

export default function Summary() {
const {
fastMode,
Expand Down Expand Up @@ -205,18 +251,27 @@ export default function Summary() {
setAddedToMetamask(true);
}
})
.catch((error: any) => {
.catch((error: unknown) => {
const code = getWalletErrorCode(error);
const message = getWalletErrorMessage(error);

// ignore 4001 "user rejected request" error code
if (error.code === 4001) {
if (code === 4001) {
// do nothing
} else if (error.message.includes('is not a function')) {
} else if (isSuccessfulMetaMaskAddError(error)) {
/**
* MetaMask v12.14.2 introduced bug with switching networks. Since it succeeds, we still change the text to mark this as successful.
* MetaMask can add the custom mainnet RPC and still reject with
* a provider error. Since the wallet state succeeded, mark the
* UI as successful instead of surfacing a false alert.
* @see https://github.com/MetaMask/metamask-extension/issues/31464
*/
setAddedToMetamask(true);
} else {
alert(`Error ${error.code}: ${error.message}`);
alert(
`Error ${code ?? 'unknown'}: ${
message || 'Unable to add Flashbots Protect RPC.'
}`,
);
}
});
} else {
Expand Down