fix sync-maintainers parser for subgroup table format#2228
Open
false200 wants to merge 1 commit into
Open
Conversation
Signed-off-by: false200 <214800619+false200@users.noreply.github.com>
false200
force-pushed
the
fix/sync-maintainers-parser
branch
from
July 25, 2026 08:08
a7cf237 to
a931cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sync-maintainers parser for the new MAINTAINERS.md layout
Fixes #2227
The central
MAINTAINERS.mdfile was rewritten to use maintainer subgroup tables.sync-maintainers.pystill parsed the old### repoblock format, so./sync-maintainers.py listprinted nothing and therepoandgithubcommands had no repos to work on.This change parses repos and maintainers from the Maintainer Subgroups table instead. Maintainer entries are written as
* @userlines so the existingget_assignees()logic still works. Also fixes the success log that was printing the literal text{repo_name} ok.How to use
From the
sync-maintainers/directory, install dependencies and run the list command.You should see 15 repo names from the subgroup table (nebraska, mantle, sysext-bakery, and the rest). Before this change the command returned no output. Cross check that list against the Repositories column in the Maintainer Subgroups table in
MAINTAINERS.md.Testing done
Ran from
sync-maintainers/on Windows with Python 3.Output:
Also verified in Python that
parse_maintainers()returns 15 repos, the intro paragraph is still read correctly, andnebraskagets the six maintainers from the nebraska-maintainers subgroup row with valid assignee usernames.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Not applicable for this change. This PR only touches the maintainer sync script in the Flatcar meta repo.