Move appindicator to shared-modules, update metainfo, other misc changes#305
Open
AKoskovich wants to merge 13 commits intoflathub:masterfrom
Open
Move appindicator to shared-modules, update metainfo, other misc changes#305AKoskovich wants to merge 13 commits intoflathub:masterfrom
AKoskovich wants to merge 13 commits intoflathub:masterfrom
Conversation
This can be automatically handled by the snapcraft x-checker-data.
This way it is easier to tell what we change over the base upstream desktop file.
/extra/bin/spotify is just a symlink so just move everything in /extra/share/spotify to /extra/.
The majority of this description was taken from the MS store since it's more recent (snap package doesn't really get updated, at least for metainfo) but added the disclaimer the snap package adds about Linux not being an actively supported platform.
[nexus@prism com.spotify.Client]$ appstreamcli validate com.spotify.Client.metainfo.xml I: com.spotify.Client:7: developer-name-tag-deprecated I: com.spotify.Client:~: developer-info-missing
desktop is the older type identifier for desktop-applications and should not be used for new metainfo files, unless compatibility with very old AppStream tools (pre 2016) is still wanted.
Spotify Premium is pushed heavily on the platform to unlock features that do not exist on the free version.
Contributor
|
Started test build 151052 |
Contributor
|
Build 151052 successful |
AKoskovich
commented
Oct 1, 2024
com.spotify.Client.metainfo.xml
Outdated
| <release date="2018-09-15" version="1.0.89.313"/> | ||
| </releases> | ||
| <branding> | ||
| <color type="primary">#1ed760</color> |
Contributor
Author
There was a problem hiding this comment.
Actually need to make this black/white, and update metainfo with an icon specifically to use for marketplaces (so the icon is not always filled with black).
Contributor
Author
There was a problem hiding this comment.
Just ended up adding a monochrome logo so we can still use the spotify green branding color.
@razzeee Does this look right?
Contributor
Author
There was a problem hiding this comment.
Hmmm the mono logo would look stange with just the default Flathub dark theme behind it though.
Contributor
Author
There was a problem hiding this comment.
Just dropping the commit from this PR until I can figure out a better way to do this
AKoskovich
force-pushed
the
extra-misc-changes
branch
from
a302101 to
6a19060
Compare
Also drop the other <provides> element, was running into validation errors and noticed it. There's no point to explicitly saying in metadata that we provide that desktop file.
The internet field is a bit tricky, I wanted to put 'first-run' since you can technically launch it, log in, download music, and never have it connect to the internet again. However the appstream spec defines first-run as: "Uses the internet the first time the application is run, but not normally afterwards." Which is not reflective of the Spotify experience. Most users will connect after first-run. We can't put it in the recommends element either since the spec says for that: "...then this indicates that the app can work without internet, but the experience will be degraded." Which is also not accurate since it has to log in at least once, so just put always. https://support.spotify.com/us/article/audio-quality
AKoskovich
force-pushed
the
extra-misc-changes
branch
from
6a19060 to
8bed114
Compare
Contributor
|
Started test build 151077 |
Contributor
|
Build 151077 successful |
Contributor
Author
|
@TingPing bonk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.