Skip to content

Disable FFlags#77

Closed
thegreatGreenstar wants to merge 10 commits intoflathub:masterfrom
thegreatGreenstar:disable-flags
Closed

Disable FFlags#77
thegreatGreenstar wants to merge 10 commits intoflathub:masterfrom
thegreatGreenstar:disable-flags

Conversation

@thegreatGreenstar
Copy link
Copy Markdown

Mostly self-explanatory: Avoids setting stuff we don't need to and risking user security. (We should have GPU sandboxing).

To account for our changed default permissions, Wayland sector must be tweaked. This accounts for applications moving over to Wayland by default.
For us to avoid a cursed mixture of Wayland and XWayland.
If anything is broken in testing against it it's these flags, but I believe there should be no issues. In a moment I'll try a a test against this and if input still works in login screen I'll mark reply to this indicating such.
Regarding the "to use wayland instead"
Now an if statement is used to be more accurate against the session and how application is running against it, if we're using native x11 it says so while if using X11 against Wayland via Xwayland it says so too.
@flathubbot
Copy link
Copy Markdown
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Copy Markdown
Contributor

🚧 Started test build.

@flathubbot
Copy link
Copy Markdown
Contributor

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/269434/dev.vencord.Vesktop.flatpakref

Built for aarch64 and x86_64 architectures.

As I don't know enough about this specific thing and cannot find documentation to answer enough, for the sake of functionality I shall revert this to enabled.
@flathubbot
Copy link
Copy Markdown
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Copy Markdown
Contributor

🚧 Started test build.

@flathubbot
Copy link
Copy Markdown
Contributor

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/269459/dev.vencord.Vesktop.flatpakref

Built for aarch64 and x86_64 architectures.

@Vendicated
Copy link
Copy Markdown
Collaborator

why did you open a duplicate of https://github.com/flathub/dev.vencord.Vesktop/pull/75/changes ?

@Vendicated Vendicated closed this Mar 29, 2026
@thegreatGreenstar
Copy link
Copy Markdown
Author

This is built on top of it but does have its own changes, it's left till draft till such is implemented till then.
Specifically it regards GPU sandboxing, so we no longer disable it at the moment with this.

why did you open a duplicate of https://github.com/flathub/dev.vencord.Vesktop/pull/75/changes ?

@thegreatGreenstar
Copy link
Copy Markdown
Author

Since it was still wip draft I won't reopen this for now but will reopen it when #75 is merged.

@thegreatGreenstar
Copy link
Copy Markdown
Author

It was properly marked as WIP draft before being closed though, so for now shall remain marked improperly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants