Add logs --tail, kill, exec --workdir/--user/--env, up --wait#11
Merged
Conversation
All in the container runtime layer + CLI (no ComposeKit changes): - logs: -n/--tail N (container logs -n). - kill: new command, -s/--signal (default KILL), reverse dependency order. - exec: forward --workdir/--user/--env (container exec already accepts them). - up: --wait blocks until healthchecked services report healthy (reuses HealthChecker). Also fixes a pre-existing bug: logs' --follow claimed -f, which collides with the global --file -f and made ArgumentParser reject every 'logs' invocation; --follow is now long-only. Tests via the recording-shim harness for kill/logs/exec argv; 32 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small CLI/runtime additions — no ComposeKit (parser) changes. All flags verified against Apple container's command reference.
Added
logs -n/--tail N— limit to the last N lines (container logs -n).kill [services]— new command;-s/--signal(default KILL), reverse dependency order. Mirrorsstop.exec --workdir/--user/--env— forwarded tocontainer exec(it already accepts-w/-u/-e); exec previously only forwarded-i/-t.up --wait— blocks until services with a healthcheck report healthy, reusing the existingHealthChecker.Incidental fix
logs --followclaimed-f, which collided with the global--file-f— ArgumentParser rejected everycontainer compose logs …invocation ("Multiple arguments named -f").--followis now long-only. (Pre-existing; surfaced while testing.)Tests
4 new argv tests via the recording-shim harness (kill signal + order, kill default, logs -n, exec flags). Verified emitted commands via
--dry-run --verbosetoo. 32 tests pass.