Honor mode on materialized configs/secrets#14
Merged
Merged
Conversation
content:/environment: configs & secrets are written to a temp file, so we can chmod them to the requested mode (e.g. 0440). uid/gid still need root and stay warned; mode on a file: source is warned (not ours to chmod). Adds a parseMode unit test (octal / 0o / decimal-as-bits).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small secret/config polish (container-compose only; no ComposeKit change).
content:/environment:configs & secrets are materialized to a temp file we own, so we nowchmodthem to the requestedmode(e.g.0440).uid/gidstill need root → stay warned.modeon afile:source is warned (we don't own the file).parseModeaccepts0440,0o440, and a plain decimal whose value is already the mode bits (YAML may decode0440to288=0o440). Unit-tested. 33 tests pass.