Absorb the container runtime layer from ComposeKit#8
Merged
Conversation
ComposeKit became a pure spec parser; its container translation/orchestration layer now lives here as the ContainerComposeKit target (ContainerTranslator, ContainerRunner, Orchestrator, HealthChecker), with the container test suites. - Add ContainerComposeKit library target + ContainerComposeKitTests (25 tests). - Executable drops the ComposeKitContainer product dep, gains ContainerComposeKit; imports updated. - Makefile/CI now run local tests; README/PACKAGING reflect the new layout. - gitignore the swift-package-edit Packages/ symlink. Requires the next ComposeKit tag (post-0.0.2, which removed the ComposeKitContainer product); until then build with: swift package edit ComposeKit --path ../ComposeKit
ComposeKit 0.0.3 removed the ComposeKitContainer product; this repo now owns the runtime layer (ContainerComposeKit) and depends only on ComposeKit's core product. Builds and tests without a local swift-package-edit checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Draft / blocked. This depends on the ComposeKit PR that removes the
ComposeKitContainerproduct and a new ComposeKit tag (0.0.3). Until that tag exists and the pin below is bumped, CI is red and the build only works with a local checkout:swift package edit ComposeKit --path ../ComposeKit.Absorbs the container runtime layer extracted from ComposeKit (companion PR: flaticols/ComposeKit#11).
ContainerComposeKitlibrary target:ContainerTranslator,ContainerRunner,Orchestrator,HealthChecker.ContainerComposeKitTests(25 tests) — the container suites moved here, with their fixtures.ComposeKitContainerproduct dependency, gains the localContainerComposeKittarget; imports updated.swift test; README/PACKAGING reflect the new layout; gitignore theswift package editsymlink.Release sequence (must be in order)
0.0.2→0.0.3,swift package unedit ComposeKit,swift package resolve, confirm it builds without the edit.Verified locally under
swift package edit: builds, 25 tests pass,container-compose --helpworks.