feat(auth): Add multi-user RBAC with per-deployment access control #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement role-based access control system with three roles: - admin: Full access to all deployments and user management - operator: Manage assigned deployments only - viewer: Read-only access to assigned deployments Key features: - SQLite auth database at .flatrun/auth.db - User management with bcrypt password hashing - API key generation with SHA-256 hashing - Per-deployment access levels (read/write/admin) - JWT tokens with user/session claims - Permission-based middleware for route protection - Backwards compatible with legacy config API keys New endpoints: - /api/users - User CRUD operations - /api/apikeys - API key management - /api/users/:id/deployments - Deployment access control Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis pull request introduces a comprehensive and robust authentication and authorization system to the Flatrun agent. It replaces a basic token-based system with a full-fledged Role-Based Access Control (RBAC) and Attribute-Based Access Control (ABAC) model, including user management, dynamic API key generation with granular permissions, persistent sessions, and deployment-specific access controls. This is a critical upgrade that significantly enhances the security, manageability, and scalability of the agent's API. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Add per-route permission enforcement for containers, images, volumes, databases, infrastructure, scheduler, system, dns, registries, templates, and traffic (33 new permission constants). Routes previously only required authentication. Add per-user custom permission overrides stored in the users table. Update role defaults so admins get all permissions, operators get read/write, and viewers get read-only. Filter deployment stats in /api/stats by user access and strip stats from the public /api/health endpoint to prevent leaking global deployment counts to unauthorized users. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/api-key-rbac
branch
from
5ab64e2 to
edb65e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement role-based access control system with three roles:
Key features:
New endpoints: