feat(credentials): track registry credentials for private deployments #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CredentialID field to ServiceMetadata to associate registry credentials with deployments. This allows the system to authenticate with private registries when pulling images on restart/update. - Store credential ID during deployment creation (existing or new) - Login with stored credential before pulling deployment images - Add serialization tests for YAML/JSON credential_id field Note: UI types (ui/src/types/index.ts) need separate update.
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CredentialID field to ServiceMetadata to associate registry credentials with deployments. This allows the system to authenticate with private registries when pulling images on restart/update.
Note: UI types (ui/src/types/index.ts) need separate update.
Closes : #60