fix(api): Merge metadata on partial updates instead of replacing #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
The updateDeploymentMetadata endpoint now properly merges incoming fields with existing metadata instead of replacing the entire object. This prevents accidental data loss when updating only specific fields like credential_id or networking settings. - Parse raw JSON to detect which fields were actually sent - Only update fields that are present in the request - Preserve existing values for fields not included in the update - Add comprehensive tests for merge behavior Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/metadata-update-partial-merge
branch
from
9236d54 to
5f52195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updateDeploymentMetadata endpoint now properly merges incoming fields with existing metadata instead of replacing the entire object. This prevents accidental data loss when updating only specific fields like credential_id or networking settings.