Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Jan 14, 2026

  • Add DNS section to sidebar navigation
  • Add DnsZonesView for PowerDNS zone/record management
  • Add DnsExternalView for external DNS providers
  • Add API clients for PowerDNS and external DNS providers
  • Add DNS store for state management
  • Add routes for /dns/zones and /dns/external

@sourceant
Copy link

sourceant bot commented Jan 14, 2026

Code Review Summary

✨ This pull request introduces comprehensive DNS management capabilities, split into two new views: one for external DNS providers and another for a self-hosted PowerDNS server. It includes new API service definitions, a Pinia store for state management, and updates to the dashboard layout and router. The implementation is robust, adheres to existing project patterns, and covers a wide range of functionalities, including provider integration, zone listing, and record CRUD operations.

🚀 Key Improvements

  • New dnsApi and powerDnsApi in src/services/api.ts provide a well-defined interface for DNS operations.
  • A dedicated useDnsStore in src/stores/dns.ts centralizes state management for external DNS providers, improving maintainability.
  • Two new feature-rich views (DnsExternalView.vue, DnsZonesView.vue) offer distinct UIs for external and self-hosted DNS, complete with dynamic forms, modals, and data tables.
  • The integration into DashboardLayout.vue and router/index.ts is seamless, providing new navigation and breadcrumb support for the DNS sections.

💡 Minor Suggestions

  • Enhance placeholder text in DnsExternalView.vue to be dynamically specific to the selected record type for improved UX.
  • Adjust the initial state of the priority field in DnsZonesView.vue to undefined to better reflect its optional nature and align with API types.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

- Add DNS section to sidebar navigation
- Add DnsZonesView for PowerDNS zone/record management
- Add DnsExternalView for external DNS providers
- Add API clients for PowerDNS and external DNS providers
- Add DNS store for state management
- Add routes for /dns/zones and /dns/external

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 14, 2026

Deploying flatrun-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb6d52f
Status: ✅  Deploy successful!
Preview URL: https://db226c23.flatrun-ui.pages.dev
Branch Preview URL: https://feat-dns-ui.flatrun-ui.pages.dev

View logs

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@flatrun flatrun deleted a comment from openhands-ai bot Jan 14, 2026
Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@flatrun flatrun deleted a comment from openhands-ai bot Jan 26, 2026
Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

- Extract lines of duplicated CSS into shared dns-shared.css
- Add clarity to "Auto" TTL option in external DNS (explains provider default)
- Add TTL validation hints and min/max bounds for PowerDNS
- Both views now import shared styles, reducing duplication significantly

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@nfebe nfebe merged commit a5ee392 into main Jan 26, 2026
5 checks passed
@nfebe nfebe deleted the feat/dns-ui branch January 26, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants