-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add DNS management UI #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nfebe
commented
Jan 14, 2026
- Add DNS section to sidebar navigation
- Add DnsZonesView for PowerDNS zone/record management
- Add DnsExternalView for external DNS providers
- Add API clients for PowerDNS and external DNS providers
- Add DNS store for state management
- Add routes for /dns/zones and /dns/external
Code Review Summary✨ This pull request introduces comprehensive DNS management capabilities, split into two new views: one for external DNS providers and another for a self-hosted PowerDNS server. It includes new API service definitions, a Pinia store for state management, and updates to the dashboard layout and router. The implementation is robust, adheres to existing project patterns, and covers a wide range of functionalities, including provider integration, zone listing, and record CRUD operations. 🚀 Key Improvements
💡 Minor Suggestions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
- Add DNS section to sidebar navigation - Add DnsZonesView for PowerDNS zone/record management - Add DnsExternalView for external DNS providers - Add API clients for PowerDNS and external DNS providers - Add DNS store for state management - Add routes for /dns/zones and /dns/external Signed-off-by: nfebe <fenn25.fn@gmail.com>
Deploying flatrun-ui with
|
| Latest commit: |
bb6d52f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db226c23.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-dns-ui.flatrun-ui.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
- Extract lines of duplicated CSS into shared dns-shared.css - Add clarity to "Auto" TTL option in external DNS (explains provider default) - Add TTL validation hints and min/max bounds for PowerDNS - Both views now import shared styles, reducing duplication significantly Signed-off-by: nfebe <fenn25.fn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.