remove removesuffix to support python 3.8#33
Open
th3w1zard1 wants to merge 1 commit intofleetingbytes:masterfrom
Open
remove removesuffix to support python 3.8#33th3w1zard1 wants to merge 1 commit intofleetingbytes:masterfrom
removesuffix to support python 3.8#33th3w1zard1 wants to merge 1 commit intofleetingbytes:masterfrom
Conversation
Owner
|
Thanks for the PR, but I don't feel very compelled to merge it. Python 3.8 will be end-of-lifed in October 2024 (tomorrow). I understand that under Windows 7 you have no other option, but for that case you can use your fork. The other reason I don't want to merge it is that the current code base needs a clean up along the lines of Bob Martin's Clean Code guidelines. I may decide to make it compatible once I'll be refactoring it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a rtf parser for python 3.8 and this was the closest library I could find that met my purposes. Python 3.8 is the last supported python version on windows 7 which unfortunately I need to target.
This library contained a single incompatibility:
removesuffix. Like most of 3.9's changes, it can easily be rewritten to support 3.8's functionality.I have been using this library for over an hour and have not found any other incompatibilities with python 3.8.
if there are any other code segments this PR can backport please let me know.