Fix FormTokenField suggestions dropdown flashing closed on click#23
Merged
flexseth merged 2 commits intofeature/form-token-fieldfrom Feb 23, 2026
Merged
Fix FormTokenField suggestions dropdown flashing closed on click#23flexseth merged 2 commits intofeature/form-token-fieldfrom
flexseth merged 2 commits intofeature/form-token-fieldfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…h and close Co-authored-by: flexseth <3792502+flexseth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address CSS and event handling feedback on FormTokenField docs
Fix FormTokenField suggestions dropdown flashing closed on click
Feb 23, 2026
Owner
|
Make FormTokenField more usable.. this needs to be tested in WordPress to see how it works. |
flexseth
approved these changes
Feb 23, 2026
Owner
flexseth
left a comment
There was a problem hiding this comment.
User experience is much more predictable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the token field contained enough tags to wrap to multiple lines, clicking anywhere in the field caused the suggestions dropdown to appear briefly then immediately close.
Root Cause
A blur/focus race condition in the
onBlurhandler. The timer ID was discarded, so when clicking the container caused a blur→refocus cycle, the stale timer always won:setTimeout(() => setIsOpen(false), 150)fires (ID discarded)setIsOpen(true)setIsOpen(false)✗Fix
Track the timer in a
blurTimerRefand cancel it on focus:Also added a
useEffectcleanup to clear any pending timer on unmount.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.