Skip to content

EDM-3402: Use control variant for RichTextFIeld#545

Open
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3402-show-constrol-input
Open

EDM-3402: Use control variant for RichTextFIeld#545
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3402-show-constrol-input

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Feb 25, 2026

Using the control variant makes it visually clearer that the field has the same size as the rest of the fields.

control-added

Summary by CodeRabbit

  • Style
    • Updated button styling in form validation notifications for improved visual appearance.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a79e591 and 8fb4cf7.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/form/RichValidationTextField.tsx

Walkthrough

A Button component variant inside a validation popover is updated from "plain" to "control" styling within RichValidationTextField.tsx. This is a single-line styling adjustment with no impact on behavior or control flow.

Changes

Cohort / File(s) Summary
Button Styling Update
libs/ui-components/src/components/form/RichValidationTextField.tsx
Button variant prop changed from "plain" to "control" within the validation popover for updated visual presentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references 'RichTextField' but the actual change is in 'RichValidationTextField', and contains a typo ('RichTextFIeld' instead of 'RichTextField'). The change is related to the variant update, which matches the objective. Correct the typo and component name: 'EDM-3402: Use control variant for RichValidationTextField' to accurately reflect the modified component.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant