-
Notifications
You must be signed in to change notification settings - Fork 22
EDM-3383: Refresh device before displaying YAML #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
celdrake
wants to merge
1
commit into
flightctl:main
Choose a base branch
from
celdrake:EDM-3383-refresh-device-in-yaml-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
libs/ui-components/src/components/Device/DeviceDetails/DeviceYamlTab.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import React from 'react'; | ||
| import { Bullseye, Spinner } from '@patternfly/react-core'; | ||
|
|
||
| import { Device } from '@flightctl/types'; | ||
| import YamlEditor from '../../common/CodeEditor/YamlEditor'; | ||
| import { showSpinnerBriefly } from '../../../utils/time'; | ||
| import { useTranslation } from '../../../hooks/useTranslation'; | ||
|
|
||
| const YAML_TAB_REFETCH_DELAY_MS = 500; | ||
|
|
||
| const DeviceYamlTab = ({ | ||
| device, | ||
| refetch, | ||
| editDisabledReason, | ||
| canEdit, | ||
| }: { | ||
| device: Required<Device>; | ||
| refetch: VoidFunction; | ||
| editDisabledReason?: string; | ||
| canEdit: boolean; | ||
| }) => { | ||
| const { t } = useTranslation(); | ||
| const [ready, setReady] = React.useState(false); | ||
|
|
||
| React.useEffect(() => { | ||
| // We want the YAML editor to open with the latest device version from the beginning. | ||
| // We add a delay that should be enough for refetch to have finished | ||
| const updateDevice = async () => { | ||
| refetch(); | ||
| setReady(false); | ||
| await showSpinnerBriefly(YAML_TAB_REFETCH_DELAY_MS); | ||
| setReady(true); | ||
| }; | ||
| void updateDevice(); | ||
| }, [refetch]); | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (!ready) { | ||
| return ( | ||
| <Bullseye> | ||
| <Spinner size="lg" aria-label={t('Refreshing device')} /> | ||
| </Bullseye> | ||
| ); | ||
| } | ||
|
|
||
| return <YamlEditor apiObj={device} refetch={refetch} disabledEditReason={editDisabledReason} canEdit={canEdit} />; | ||
| }; | ||
|
|
||
| export default DeviceYamlTab; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.