Skip to content

EDM-3395: Ensure paddings are defined for main components #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celdrake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EDM-3395: Ensure paddings are defined for main components #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions apps/ocp-plugin/src/components/common/WithPageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ import PageNavigation from '@flightctl/ui-components/src/components/common/PageN
import { SystemRestoreProvider } from '@flightctl/ui-components/src/hooks/useSystemRestoreContext';
import { PermissionsContextProvider } from '@flightctl/ui-components/src/components/common/PermissionsContext';

// The OCP console uses "calc" to calculate padding values for page containers and breadcrumbs.
// But some CSS variables it uses are undefined, so the "calc" values are invalid.
const ocpPageRootStyles: React.CSSProperties = {
// Ensure page containers have inline padding
['--pf-v6-c-page__main-container--BorderInlineEndWidth' as string]: '0px',
Copy link
Collaborator Author

@celdrake celdrake Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "0" does not seem to work with the calc expressions

.pf-v6-c-page__main-section.pf-m-padding {
  padding-block-start: var(--pf-v6-c-page__main-section--PaddingBlockStart);
  padding-block-end: var(--pf-v6-c-page__main-section--PaddingBlockEnd);
  padding-inline-start: calc(var(--pf-v6-c-page__main-section--PaddingInlineStart) - var(--pf-v6-c-page__main-container--BorderInlineStartWidth));
  padding-inline-end: calc(var(--pf-v6-c-page__main-section--PaddingInlineEnd) - var(--pf-v6-c-page__main-container--BorderInlineEndWidth));
}

['--pf-v6-c-page__main-container--BorderInlineStartWidth' as string]: '0px',
// Ensure page breadcrumbs have inline padding
['--pf-v6-c-page__main-breadcrumb--PaddingInlineStart' as string]: '1rem',
['--pf-v6-c-page__main-breadcrumb--PaddingInlineEnd' as string]: '1rem',
};

const WithPageLayoutContent = ({ children }: React.PropsWithChildren) => {
const { mustShowOrganizationSelector } = useOrganizationGuardContext();

Expand All @@ -15,10 +26,10 @@ const WithPageLayoutContent = ({ children }: React.PropsWithChildren) => {
}

return (
<>
<div style={ocpPageRootStyles}>
<PageNavigation showSettings={false} />
{children}
</>
</div>
);
};

Expand Down