Skip to content

EDM-2851 openshift login #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
celdrake wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

EDM-2851 openshift login #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4526281
EDM-2851: Do not clear OCP cookies on logout
celdrake Mar 4, 2026
f3210fe
Do not combine prompt values
celdrake Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions proxy/auth/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ func loginRedirect(client *osincli.Client, state string, codeChallenge string) s
query.Set("code_challenge_method", "S256")

// Force that when a new auth flow starts, the user is prompted to select
// their account and enter credentials, even if they're already logged in
// their account, even if they're already logged in
// Does not work for all providers (eg. OpenShift)
query.Set("prompt", "login select_account")
query.Set("prompt", "select_account")

parsedURL.RawQuery = query.Encode()

Expand Down Expand Up @@ -318,8 +318,6 @@ func clearSessionCookie(w http.ResponseWriter, r *http.Request) {
SameSite: http.SameSiteLaxMode,
}
http.SetCookie(w, &cookie)

w.Header().Set("Clear-Site-Data", `"cookies"`)
}

// validateAndExtractProviderFromState validates the state parameter and extracts the provider name
Expand Down