Skip to content

EDM-3332: Prevent copy button border from being cut#560

Open
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3332-fix-cut-copy-button
Open

EDM-3332: Prevent copy button border from being cut#560
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3332-fix-cut-copy-button

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Mar 4, 2026

Fixes a visual issue that was happening only in Firefox.

Summary by CodeRabbit

  • Style
    • Enhanced visual styling for the login command modal's copy functionality with improved CSS styling.

@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 421d4108-788b-4afc-8ca6-a82afacc00c9

📥 Commits

Reviewing files that changed from the base of the PR and between 06b11e2 and fd1a01f.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/modals/LoginCommandModal/LoginCommandModal.tsx

Walkthrough

A CSS class (fctl-login-command-modal__clipboard-copy) was added to the ClipboardCopy component in the LoginCommandModal, along with a CSS import statement. The component's existing functionality and props remain unchanged.

Changes

Cohort / File(s) Summary
LoginCommandModal Styling
libs/ui-components/src/components/modals/LoginCommandModal/LoginCommandModal.tsx
Added CSS import and applied new CSS class to ClipboardCopy component for targeted styling. Existing props (isReadOnly, hoverTip, clickTip) preserved without functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main visual fix: preventing a copy button border from being cut off in the LoginCommandModal component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant