Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a special
gr_ctx_uninitializedconstructor and call this in GR context initializers that have the ability to fail, e.g.mpn_modwith a modulus that is out of range. This makes it a bit forgiving to write wrappers and cleanup blocks for generics, since it becomes safe to callgr_ctx_cleareven if initialization failed. Indeed, thanks to this change context initialization should now fail gracefully in the ctypes wrapper instead of randomly segfaulting.IIRC @mezzarobba requested something like this.
Not sure if we should actually call
gr_ctx_uninitializedin the failing constructors ourselves or leave this to the user? I made this automatic for now in all places I could think of, but I don't have a strong opinion either way.Also, add ctypes wrapper for
gr_fractionwith some tests.