Make --disable-assembly disable inline assembly#2593
Merged
albinahlback merged 2 commits intoflintlib:mainfrom Mar 6, 2026
Merged
Make --disable-assembly disable inline assembly#2593albinahlback merged 2 commits intoflintlib:mainfrom
--disable-assembly disable inline assembly#2593albinahlback merged 2 commits intoflintlib:mainfrom
Conversation
wegank
reviewed
Mar 6, 2026
Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
wegank
reviewed
Mar 6, 2026
| # if defined(__clang__) | ||
| # include "longlong_asm_clang.h" | ||
| # else | ||
| # elif FLINT_WANT_ASSEMBLY |
Contributor
There was a problem hiding this comment.
In my case, Fil-C is based on Clang, so the check doesn't work.
Collaborator
Author
There was a problem hiding this comment.
You mean that you do not want to include longlong_asm_clang.h? In that case, Fil-C is sensitive to builtins. Is this correct?
Collaborator
Author
|
That doesn't answer my question. Which header or piece of code is Fil-C
sensitive to in this case?
…On Fri, Mar 6, 2026, 17:22 Weijia Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/longlong.h
<#2593 (comment)>:
> @@ -46,13 +46,14 @@ extern "C" {
/* Addition, subtraction and multiplication */
# if defined(__clang__)
# include "longlong_asm_clang.h"
-# else
+# elif FLINT_WANT_ASSEMBLY
In the Fil-C model, everything FLINT depends on (including libc) must be
compiled by Fil-C, so this is not a problem. See https://fil-c.org/runtime
.
—
Reply to this email directly, view it on GitHub
<#2593 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGBZ5ZTYVDSNXESCGGUEQD4PL3N5AVCNFSM6AAAAACWJM5T4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMBUGY4TEMBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Fil-C was sensitive to the built-in |
wegank
approved these changes
Mar 6, 2026
Contributor
wegank
left a comment
wegank
left a comment
There was a problem hiding this comment.
Fil-C is now happy. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disable-assemblydid not disable inline assembly before.@wegank can you verify whether this fixes your problem?