Add ArrowUp/ArrowDown keyboard navigation from toolbox search input #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
keydownlistener to the search input increateDom_()ofnode_modules/@blockly/toolbox-search/src/toolbox_search.tsthat handlesArrowDownandArrowUpkeys.event.preventDefault(), blurs the search input viagetFocusableElement().blur(), computes the adjacent toolbox item usingthis.parentToolbox_.getToolboxItems()and the current index, and then moves selection and focus to that item by callingthis.parentToolbox_.setSelectedItem(nextItem)(if selectable) andBlockly.getFocusManager().focusNode(nextItem).Escapebehavior and existingkeyupsearch/match logic are preserved.toolbox_search.tsand use the focus APIs already exposed by Blockly (getFocusableElement()andgetFocusManager().focusNode).Testing
Codex Task