fix(react,vue): forward multiCursor through Editor components#130
Open
karen1522158173 wants to merge 1 commit into
Open
fix(react,vue): forward multiCursor through Editor components#130karen1522158173 wants to merge 1 commit into
karen1522158173 wants to merge 1 commit into
Conversation
|
刘凯伦 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Forward
multiCursorfrom the React/Vue<Editor />wrapper components to the core editor config.Motivation / 背景与动机
The core editor already supports the
multiCursoroption, and both React/VueuseEditorhooks can pass editor config through tocreateEditor.However, the React and Vue
<Editor />wrapper components did not forward themultiCursorprop to the core editor config. In React, the prop could also be forwarded to the DOM wrapper instead of being consumed by the editor component.This PR fixes the wrapper behavior so framework users can enable or disable multi-cursor support through the existing
multiCursorprop.Changes / 变更内容
packages/react:multiCursorfrom the React<Editor />component touseEditor.multiCursor={true}andmultiCursor={false}.packages/vue:multiCursorto Vue editor prop keys and runtime props.multiCursoris included in the config passed touseEditor.multiCursor: trueandmultiCursor: false.packages/core:multiCursor.Validation / 验证
pnpm test -- packages/react/test/editor-react.test.tsx packages/vue/test/editor-vue.test.tspnpm test -- packages/core/test/multi-cursor.test.tspnpm typecheckCompliance / 合规自检
AI-assisted notes: Used AI assistance to analyze the issue, draft test ideas, and review the implementation plan. The final diff was manually inspected and verified locally with tests and typecheck.
Checklist / 自检清单
multiCursorwas already present in the public Editor props type; this PR fixes wrapper forwarding behavior.live-preview-table.ts→ reviewed the 12 table Widget rules inCLAUDE.md: N/A, not touched.Screenshots / Recordings · 截图或录屏
N/A, no visible UI change.