Skip to content

fix(react,vue): forward multiCursor through Editor components#130

Open
karen1522158173 wants to merge 1 commit into
floatboatai:mainfrom
karen1522158173:fix/react-vue-multicursor-prop
Open

fix(react,vue): forward multiCursor through Editor components#130
karen1522158173 wants to merge 1 commit into
floatboatai:mainfrom
karen1522158173:fix/react-vue-multicursor-prop

Conversation

@karen1522158173

@karen1522158173 karen1522158173 commented Jul 5, 2026

Copy link
Copy Markdown

Summary / 摘要

Forward multiCursor from the React/Vue <Editor /> wrapper components to the core editor config.

Motivation / 背景与动机

  • Issue: N/A
  • Roadmap: N/A
  • OpenSpec change: N/A

The core editor already supports the multiCursor option, and both React/Vue useEditor hooks can pass editor config through to createEditor.

However, the React and Vue <Editor /> wrapper components did not forward the multiCursor prop to the core editor config. In React, the prop could also be forwarded to the DOM wrapper instead of being consumed by the editor component.

This PR fixes the wrapper behavior so framework users can enable or disable multi-cursor support through the existing multiCursor prop.

Changes / 变更内容

  • packages/react:

    • Forward multiCursor from the React <Editor /> component to useEditor.
    • Add regression tests for both multiCursor={true} and multiCursor={false}.
  • packages/vue:

    • Add multiCursor to Vue editor prop keys and runtime props.
    • Ensure multiCursor is included in the config passed to useEditor.
    • Add regression tests for both multiCursor: true and multiCursor: false.
  • packages/core:

    • No changes. Core already supports multiCursor.

Validation / 验证

  • pnpm test -- packages/react/test/editor-react.test.tsx packages/vue/test/editor-vue.test.ts
  • pnpm test -- packages/core/test/multi-cursor.test.ts
  • pnpm typecheck
  • Manual UI check in electron-demo / electron-demo 手动验证: N/A, no visible UI change

Compliance / 合规自检

  • CLA signed — first-time contributors will be prompted automatically by the CLA bot.
  • AI disclosure: the functional code in this PR is not primarily generated by AI. AI assistance, if any, is described below.
    AI-assisted notes: Used AI assistance to analyze the issue, draft test ideas, and review the implementation plan. The final diff was manually inspected and verified locally with tests and typecheck.
  • New dependencies: none.
  • No build artifacts committed.
  • No secrets / personal vault data committed.

Checklist / 自检清单

  • Title follows Conventional Commits.
  • Public API changes update package README / types: multiCursor was already present in the public Editor props type; this PR fixes wrapper forwarding behavior.
  • Touched live-preview-table.ts → reviewed the 12 table Widget rules in CLAUDE.md: N/A, not touched.
  • Change aligns with project scope.
  • New capability / breaking change → OpenSpec proposal linked: N/A, this is a wrapper forwarding bugfix.

Screenshots / Recordings · 截图或录屏

N/A, no visible UI change.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


刘凯伦 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants