fix: stabilize markdown table search and selection#137
Open
2391384896 wants to merge 4 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FloatinsideFloatboat,PinsideP1, orKevininsideKevin Stratvertdoes not become whole-cell editing/selection.Verification
pnpm exec vitest run packages/plugin-search/test/plugin-search.test.ts→ pass (30 tests)pnpm exec vitest run packages/core/test/live-preview.test.ts→ pass (69 tests)pnpm typecheck→ passpnpm --filter @floatboat/nexus-core build→ passpnpm --filter @floatboat/nexus-plugin-search build→ passgit diff --check→ passABCwithout DOM/focus loss;Floatpartial selection stayed partial;Cmd+Ftable search selectedSearchNeedle070./Users/zhenyu/Downloads/Floatboat table ime repro.md→ pass: 第 38 行| | aa | ... | nnasaaan | ... |首格 composition 输入你好时中间态n不写入文档、不失焦;blur 后目标行仍停在表格可见区域,未跳到评论样本摘录。