feat: collapse quoted reply text#1612
Conversation
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @Shabhareash! Please fix the following issues with your PR:
- Title: Is too long (54 characters). The PR title must be strictly under 40 characters.
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
Formatting issues have been resolved. Thank you!
|
@Shabhareash this feature is supposed to go to |
Detect quoted/reply blocks (styled in rounded-border boxes) and collapse them into a single '▶ quoted text hidden' indicator by default. Pressing 'q' (configurable via toggle_quotes keybind) expands/collapses the quoted sections. Changes: - view/html.go: add CollapseQuotedText() that identifies rendered quote boxes by their ╭/╰ border chars and replaces them with a one-line summary - tui/email_view.go: add showQuotedText toggle, collapse quotes by default, re-render body on toggle; add 'q: toggle quotes' to help bar - config: add toggle_quotes keybind (default: q) to EmailKeys Closes floatpane#1612
3c7f428 to
98f7b27
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
There was a problem hiding this comment.
-
qis definitely taken by q(uit) (hardcoded), lets choose a different default keybind -
The key help is written (i like the one that is in the email more)
- Should be a new line, and not spaced out (word wrapped)
- I think an email should be there, empty instead
- Wednesday is not with the date,
- Name is trailing, i think you can make it
from Name (address@email.com)
Also, if you could add it to command palette, that would be great!
What?
Detect quoted/reply blocks (styled in rounded-border boxes) and collapse them into a single '▶ quoted text hidden' indicator by default. Pressing 'q' (configurable via toggle_quotes keybind) expands/collapses the quoted sections.
Changes:
Why?
Closes #1598