Skip to content

fix(api): resolve legacy approval batch shares#2016

Merged
itachi-hue merged 2 commits into
mainfrom
fix/approval-share-legacy-fallback
Jun 26, 2026
Merged

fix(api): resolve legacy approval batch shares#2016
itachi-hue merged 2 commits into
mainfrom
fix/approval-share-legacy-fallback

Conversation

@federicodeponte

Copy link
Copy Markdown
Member

Summary

  • routes legacy standalone approval batch share rows through the public batch payload without reloading through the canonical share_links repository
  • keeps canonical revoked/expired share_links rejection intact for both /approvals/public-batch and /s
  • updates regression coverage for the legacy /s fallback

Verification

  • cd apps/api && python3 -m pytest tests/test_approvals_batch_share_link.py -q
  • 19 passed, 1 warning in 30.44s

@federicodeponte federicodeponte force-pushed the fix/approval-share-legacy-fallback branch from 43d58b4 to c39ec1e Compare June 25, 2026 22:22
@itachi-hue itachi-hue merged commit 29ed864 into main Jun 26, 2026
7 checks passed
@itachi-hue itachi-hue deleted the fix/approval-share-legacy-fallback branch June 26, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants