fix(clipboard): prefer tmux load-buffer and pbcopy writes#366
Merged
lavaman131 merged 1 commit intomainfrom Mar 5, 2026
Merged
fix(clipboard): prefer tmux load-buffer and pbcopy writes#366lavaman131 merged 1 commit intomainfrom
lavaman131 merged 1 commit intomainfrom
Conversation
Use tmux's native load-buffer clipboard path inside tmux sessions and prefer pbcopy on macOS for reliable multiline copy behavior. Update clipboard tests to verify tmux/native command selection and exact OSC52 output. Assistant-model: openai/gpt-5.3-codex
Code Review: fix(clipboard): prefer tmux load-buffer and pbcopy writesSummary: This PR improves clipboard reliability by prioritizing native clipboard commands in tmux sessions and on macOS. The changes are well-reasoned and address real-world clipboard failures. Strengths: Clean, well-documented implementation. Security improvement by using pbcopy with stdin instead of osascript escaping. Good test coverage for the new behaviors. Concerns: (1) tmux -w flag requires tmux 3.2+ (April 2021) - consider fallback or documentation. (2) osascript escaping is incomplete for newlines (low priority since pbcopy is now preferred). (3) Consider edge case tests for TMUX env set without tmux command. Verdict: LGTM with minor suggestions. The core changes are solid improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR improves clipboard reliability in terminal workflows by preferring tmux-native and macOS-native copy commands while still emitting OSC 52, reducing failures in tmux sessions and avoiding AppleScript escaping edge cases on macOS.
Changes:
Technical Context:
The previous implementation wrapped OSC 52 in tmux DCS passthrough sequences, which required allow-passthrough setting. The new approach uses tmux native clipboard commands that work out of the box. On macOS, pbcopy is simpler than osascript and avoids string escaping edge cases.