Add line width argument for SVG preview and export#840
Open
MartinScharrer wants to merge 1 commit into
Open
Conversation
MartinScharrer
force-pushed
the
linewidth
branch
from
253a148 to
10feb4c
Compare
Contributor
Author
|
Fixes #607 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a line width argument which allows the setting of the SVG line with independent of the burn parameter.
This was requested originally by #607 as the user there seems to use a laser engraving software which needs a line width of 0.001mm for burning but engraves thicker lines instead. The current implementation enforces a minimum of 0.05mm.
I also like to set the burn parameter to 0 and use LigthBurn's kerf offset setting instead, but find the 0.05mm minimum hard to view on the SVG preview. I therefore would also like to see such a parameter.
I implemented it in a way, that the value is an empty string by default and then follows the original value of min(2x burn, 0.05) making the change fully backward compatible.
Fixes #607.