investigated #116 and added some comments to help clarify the code#123
Merged
pavelkomarov merged 1 commit intomasterfrom Jul 2, 2025
Merged
investigated #116 and added some comments to help clarify the code#123pavelkomarov merged 1 commit intomasterfrom
pavelkomarov merged 1 commit intomasterfrom
Conversation
pavelkomarov
commented
Jul 2, 2025
| dxdt_hat_f = dxdt_hat[-1] + ddxdt_hat_f # What is this doing? Could we use a 2nd order FD above natively? | ||
| dxdt_hat = np.hstack((dxdt_hat, dxdt_hat_f)) | ||
|
|
||
| # fix first point |
Collaborator
Author
There was a problem hiding this comment.
Having to find a special last value makes sense, but I experimented for a while and determined the first point doesn't really need to be fixed. In fact, having these lines increased the error for a few of the test functions (the ones with curvature). Zooming in, you could see it in the plots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.