removed a couple unnecessary imports, reran basic_tutorial notebook (…#126
Merged
pavelkomarov merged 1 commit intohack-the-optimizer-morefrom Jul 8, 2025
Merged
Conversation
…RMS numbers worsened because no longer excluding the beginning and ends of the vectors in calculation), and changed the evaluation file because I realized padding=None makes it sound like no padding, not 2.5% padding, and padding wasn't getting used properly in the error_correlation and total_variation functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RMS numbers worsened because no longer excluding the beginning and ends of the vectors in calculation), and changed the evaluation file because I realized padding=None makes it sound like no padding, not 2.5% padding, and padding wasn't getting used properly in the error_correlation and total_variation functions