Refactor/flow 158 #315
Open
Refactor/flow 158 #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharamura
requested changes
Sep 26, 2023
src/core/persist/knex/process.js
Outdated
| .skipLocked(); | ||
| } | ||
|
|
||
| async getLocked(id, processStateId, trx) { |
Collaborator
There was a problem hiding this comment.
Fiquei na dúvida... o que estamos fazendo aqui?
Estamos fazendo o lock do processo, mas essas 2 chaves são estranhas... só se o objetivo é verificar se o processo está no state esperado.
Contributor
Author
There was a problem hiding this comment.
Isso, o objetico desse é fazer o lock e verificar se está no state esperado. Esse método especificamente só é usado pelo método __inerLoop, aí aproveitei pra mover também pra camada de persistência
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Move process methods into persist layers.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., usage docs, etc.: