Update wave_attenuation.py#897
Open
SHITIANYU-hue wants to merge 2 commits intoflow-project:masterfrom
Open
Conversation
The previous code can only display one rl vehicle, this way it can display all rl vehicles and their leader and follower vehicles, which is in accordance to the paper.
SHITIANYU-hue
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
Member
|
Hi, can you make sure this passes the test |
Author
|
Sorry, i am not quite familiar with:pydocstyle --convention numpy, but i am sure this can run successfully. |
Member
|
Hi, so we use pydoc to enforce rules on our documentation. You can run it locally by doing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code can only display one rl vehicle, this way it can display all rl vehicles and their leader and follower vehicles, which is in accordance to the paper.
Pull request information
Description
? (general description)