add sumo option of traffic scale in visualizing#898
Open
pengyuan-zhou wants to merge 4 commits intoflow-project:masterfrom
pengyuan-zhou:patch-4
Open
add sumo option of traffic scale in visualizing#898pengyuan-zhou wants to merge 4 commits intoflow-project:masterfrom pengyuan-zhou:patch-4
pengyuan-zhou wants to merge 4 commits intoflow-project:masterfrom
pengyuan-zhou:patch-4
Conversation
pengyuan-zhou
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
pengyuan-zhou
changed the title
pengyuan-zhou
changed the title
Pull Request Test Coverage Report for Build 5617
💛 - Coveralls |
|
|
||
| def __init__(self, | ||
| sim_step=0.1, | ||
| scale=1.0, |
Member
There was a problem hiding this comment.
Hi, could you add an explanation of what this does to the docstring?
Contributor
Author
There was a problem hiding this comment.
Sure thing, done :)
| def __init__(self, | ||
| port=None, | ||
| sim_step=0.1, | ||
| scale=1.0, |
Contributor
Author
|
@eugenevinitsky Hi, is there any issue with this snippet? |
eugenevinitsky
requested changes
Jun 9, 2020
Member
eugenevinitsky
left a comment
eugenevinitsky
left a comment
There was a problem hiding this comment.
Where is scale actually passed to SUMO?
Contributor
Author
Hi, it's been a while and I can't recall. But it's an official option of sumo as shown here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the title