Open
Conversation
…es are immediately put back
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
Member
Author
|
I'm not sure why this isn't getting the histories right, this is built on top of I210 dev... |
AboudyKreidieh
requested changes
Jun 10, 2020
Member
AboudyKreidieh
left a comment
AboudyKreidieh
left a comment
There was a problem hiding this comment.
@eugenevinitsky can you rebase this with i210_dev? I can review it afterwards
* added new lane change modes * replaced 'no_lat_collide' with 'no_lc_safe' which is the new default lane change mode * bug fixes and PR reviews Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The done condition is not correct for sims_per_step greater than one. Its possible a vehicle might have left during one of the steps. Additionally, fix the done condition to get set when a vehicle is on the exit edge.