Open
Conversation
…ment (ray-project#2995) * simplify vec batch requirements * Update rllib-training.rst * Update rllib-training.rst * Update rllib-training.rst * Update rllib-training.rst * Update rllib-training.rst * Update rllib-models.rst
…ors (ray-project#2967) * update * link it * warn about truncation * fix * Update rllib-training.rst * deprecate tests failing
… of PPO (ray-project#2974) * fix * fix * fix it * propagate conf to action dist * move carla example too * rr * Update policies.py * wip * lint
…ava worker. (ray-project#3002) This fixes a bug in which Java actor methods inherit the resource requirements of the actor creation task.
* remove legacy * remove reshaper
This tests the case in which a worker is blocked in a call to ray.get or ray.wait, and then the worker dies. Then later, the object that the worker was waiting for becomes available. We need to make sure not to try to send a message to the dead worker and then die. Related to ray-project#2790.
before fix,RAY_FUN_CACHE use only get method ,can only get null fix : put after create
…ay-project#3003) Move function/actor exporting & loading code to function_manager.py to prepare the code change for function descriptor for python.
This commit fix some small defects. 1. Remove a comment that should have been removed in ray-project#3003 2. Remove `redis_protected_mode` that is never used in `ray.init()` 3. Fix `object_id_seed` that is forgotten to be passed into `ray._init()` 4. Remove several redundant brackets.
…ect#2837) * Introduce concept of resources required for placement. * Add placement resources to task spec * Update java worker * Update taskinfo.java
…ject#3029) Improve logging message when plasma store is started.
* Update rsync command * Escape rsync locations * Fix the accidental variable move * Update rsync to use -s flag
## What do these changes do? 1. Add a configuration item `driver.resource-path`. 2. Load driver resources from the local path which is specified in the `ray.conf`. Before this change, we should add all driver resources(like user's jar package, dependencies package and config files) into `classpath`. After this change, we should add the driver resources into the mount path which we can configure it in `ray.conf`, and we shouldn't configure `classpath` for driver resources any more. ## Related issue number N/A
* bugfix: env exists check error * support to avoid re-build pyarrow in project * bugfix: adapt gtest for centos lib64 * bugfix: check gtest lib exists in the directory * bugfix: find gtest with checking all libs exists * prefix RAY_ to thirdparty env variables to avoid conflicts with other module * arrow use glog from ray * change the glog and gtest install dir
This PR improves some java codes, and removes some duplicated code.
## What do these changes do? Fix the issue how we load driver resources by a specified path. Also this addressed the comments from the related PR [3044](ray-project#3044). ## Related PRs: [ray-project#3044](ray-project#3044) and [ray-project#3001](ray-project#3001).
* fix er * update
…oject#3068) ## What do these changes do? Fix the misleading comments in code for: - `EPISODES_THIS_ITER` - `EPISODES_TOTAL` Had noted it before and planned to fix it along with some other changes but seemed very relevant to stay next to ray-project#3058 so sending this now.
…e to UI. (ray-project#3397) * Saving * Fix cmake and remove object/task search boxes. * Add comment
* frac ppo * gpu test
* Add script for running stress tests. * Add an actor tree test where actors die with some probability * Improve test. * Small fix * Update tests. * Minor change
…fined ObjectDirectory (ray-project#3403)
* Add regression test * Request actor creation if no actor location found * Comments * Address comments * Increase test timeout * Trigger test
* batch norm * lint * fix dqn/ddpg update ops * bn model * Update tf_policy_graph.py * Update multi_gpu_impl.py * Apply suggestions from code review Co-Authored-By: ericl <ekhliang@gmail.com>
* Adding logo to readme * Updating link * Add badge * Addressing comments * Moving logo * Change align * Move image
…t#3448) This includes a fix so the TensorFlow op releases memory properly (apache/arrow#3061) and the possibility to store arrow data structures in plasma (apache/arrow#2832). ray-project#3404
ray.wait depends on callbacks from the GCS to decide when an object has appeared in the cluster. The raylet crashes if a callback is received for a wait request that has already completed, but this actually can happen, depending on the order of calls. More precisely: 1. Objects A and B are put in the cluster. 2. Client calls ray.wait([A, B], num_returns=1). 3. Client subscribes to locations for A and B. Locations are cached for both, so callbacks are posted for each. 4. Callback for A fires. The wait completes and the request is removed. 5. Callback for B fires. The wait request no longer exists and raylet crashes.
AboudyKreidieh
approved these changes
Dec 3, 2018
Member
AboudyKreidieh
left a comment
AboudyKreidieh
left a comment
There was a problem hiding this comment.
This is too long for me to actually review. Should i look at any files specifically? If you haven't made any changes though, then LGTM
Member
|
The master branch is out of date with this ray_merge branch, can we update it? @eugenevinitsky This is actually the cause of my issues with flow-project/flow#338, in which is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the upstream master to get ray 0.5.3