Skip to content

Apply property coverage closure across adapters#18

Merged
subsetpark merged 1 commit into
masterfrom
zax/full-property-closure
Jun 8, 2026
Merged

Apply property coverage closure across adapters#18
subsetpark merged 1 commit into
masterfrom
zax/full-property-closure

Conversation

@subsetpark

@subsetpark subsetpark commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

What

Extends the property-coverage call-graph closure beyond OCaml to Go, TypeScript, and Swift, and documents the adapter contract in AGENTS.md.

Details

  • Go: treats function values passed through quick.Check property builders as API references, follows returned property functions, and filters helper/predeclared names from coverage evidence.
  • TypeScript: records non-function value bindings in the reference graph, follows returned property callbacks from builder functions, and harvests references from the whole fc.property(...) construction.
  • Swift: harvests references from the full propertyCheck(...) construction while keeping generated-input evidence tied to closure parameters.
  • OCaml fixture compatibility: adjusts the closure regression fixture to the older QCheck2 API in the local switch.
  • Agent guidance: makes call-graph closure a uniform adapter contract, not a per-rule patch.

Verification

  • just test

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@flowglad-review-service

Copy link
Copy Markdown

Review Summary

I reviewed the diff and did not identify any actionable in-scope findings to flag.

Severity Count
Must-fix 0
Should-fix 0
Note 0

Variant: convergence-v2

Candidates: 0 | Posted: 0 | Suppressed: 0


0 comments posted · Model: gpt-5.4 (sonnet) · Tokens: 146176 in / 554 out · Cache: 0 created / 85248 read · Context: 43 items · Review mode: agentic · Turns: 4 · Tool calls: 0

@subsetpark subsetpark merged commit 69dde84 into master Jun 8, 2026
7 checks passed
@subsetpark subsetpark deleted the zax/full-property-closure branch June 8, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant