ocaml: map ppx typedtree sources to real files#20
Merged
Conversation
Review SummaryStage: behavior. I reviewed the diff and did not find any actionable in-scope issues to raise.
Variant: convergence-v2 Candidates: 0 | Posted: 0 | Suppressed: 0 0 comments posted · Model: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the OCaml typedtree artifact mapper for Dune/PPX-generated source paths.
Dune records preprocessed modules in
.cmt/.cmtimetadata as paths likelib/orchestrator.pp.ml, but archlint collects the real source pathlib/orchestrator.ml. That made the adapter fail withmissing typedtree artifactseven though the artifacts existed.This normalizes full typedtree source paths from
*.pp.ml/*.pp.mliback to*.ml/*.mlibefore matching, preserving directory context so duplicate basenames likelib/git_env.mlandlib_test/git_env.mlresolve correctly.Tests
ARCHLINT_OPAM_SWITCH="$PWD/ocaml" sh ocaml/test.shuv run --project . python evaluate_test.pyuv run --project . python evaluate.py --repo-root /Users/zax/code-src/onton --adapter ocaml --ocaml-root .Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.