Skip to content

Add TypeScript dependency effect summaries#22

Merged
subsetpark merged 2 commits into
masterfrom
fixtures-for-adapter-shell-tests
Jun 8, 2026
Merged

Add TypeScript dependency effect summaries#22
subsetpark merged 2 commits into
masterfrom
fixtures-for-adapter-shell-tests

Conversation

@subsetpark

@subsetpark subsetpark commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • adds structured effectfulReferences support for TypeScript dependency-summary effects and evaluator/schema validation
  • adds npm dependency summaries for Anthropic, Trigger.dev, Effect requirements, Sentry, and OpenAI effect leaves
  • adds adapter fixtures for dependency summaries, local call expansion, workspace package expansion, and effect requirement propagation

Flowglad verification

  • npm --prefix /Users/zax/code-src/archlint/typescript run --silent typecheck
  • sh /Users/zax/code-src/archlint/typescript/test.sh
  • uv run --project /Users/zax/code-src/archlint python /Users/zax/code-src/archlint/evaluate_test.py
  • git diff --check in archlint and provisioning-agent
  • uv run --project /Users/zax/code-src/archlint python /Users/zax/code-src/archlint/evaluate.py --repo-root /Users/zax/code-src/provisioning-agent --adapter typescript --typescript-root packages/agent-kernel

Fact inspection

  • OpenAI network facts appear in packages/agent-core/src/lib/inference/openai-adapter.ts for chat.completions.create and embeddings.create
  • Sentry network facts appear in shared observability for init, captureException, and flush
  • fixture lookalikes for Sentry/OpenAI do not emit dependency-summary effects

@flowglad-review-service

Copy link
Copy Markdown

Review Summary

I reviewed the fixture-refactor patch and did not find any in-scope correctness, maintainability, or performance issues that warrant a review comment.

Severity Count
Must-fix 0
Should-fix 0
Note 0

Variant: convergence-v2

Candidates: 0 | Posted: 0 | Suppressed: 0


0 comments posted · Model: gpt-5.4 (sonnet) · Tokens: 234124 in / 309 out · Cache: 0 created / 72320 read · Context: 29 items · Review mode: agentic · Turns: 4 · Tool calls: 0

@subsetpark subsetpark changed the title Move adapter shell test sources into fixtures Add TypeScript dependency effect summaries Jun 8, 2026
@flowglad-review-service

Copy link
Copy Markdown

Review Summary

No additional findings in this delta after validation.

Severity Count
Must-fix 0
Should-fix 0
Note 0

Variant: convergence-v2

Candidates: 0 | Posted: 0 | Suppressed: 0


0 comments posted · Model: gpt-5.4 (sonnet) · Tokens: 319738 in / 835 out · Cache: 0 created / 4736 read · Review mode: agentic · Turns: 4 · Tool calls: 0

@subsetpark subsetpark merged commit 56d5f74 into master Jun 8, 2026
7 checks passed
@subsetpark subsetpark deleted the fixtures-for-adapter-shell-tests branch June 8, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant