Merged
Conversation
I hadn't added a sleep to the fibonacci test previously because the delays added by the math being performed has always been sufficient to ensure that lines sent to stdout and stderr don't arrive out of order. But apparently the hydra.nixos.org build farm has faster machines because one managed to trip the race condition: https://hydra.nixos.org/build/290187717/log Adding 10ms sleep to make it signficantly more likely that lines sent to stdout and stderr will arrive in the right order.
ysndr
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hadn't added a sleep to the fibonacci test previously because the delays added by the math being performed has always been sufficient to ensure that lines sent to stdout and stderr don't arrive out of order. But apparently the hydra.nixos.org build farm has faster machines because one managed to trip the race condition (once): https://hydra.nixos.org/build/290187717/log
Adding 10ms sleep to make it signficantly more likely that lines sent to stdout and stderr will arrive in the right order.