Merged
Conversation
Observed failed tests for the aarch64-linux build job on hydra.nixos.org: - https://hydra.nixos.org/build/292893102/nixlog/1 I'm confident the usleep() statements within midline-flush.c handles ordering within a single invocation, but the test does demonstrate that it must be possible to schedule overlapping program invocations, where the first flush of a subsequent invocation can be processed in advance of the final flush from a preceding one. This update adds a numeric identifier to each hello() and goodbye() statement, which should help to identify exactly which invocation gets out of order, and also adds a sleep in the main shell loop to make it that much less likely that this race will occur.
ysndr
approved these changes
Apr 1, 2025
Contributor
ysndr
left a comment
ysndr
left a comment
There was a problem hiding this comment.
I’m not sure if this really fixes anything, but it should make it easier to see when it goes wrong in a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed failed tests for the aarch64-linux build job on hydra.nixos.org:
I'm confident the
usleep()statements withinmidline-flush.chandles ordering within a single invocation, but the test does demonstrate that it must be possible to schedule overlapping program invocations, where the first flush of a subsequent invocation can be processed in advance of the final flush from a preceding one.This update adds a numeric identifier to each
hello()andgoodbye()statement, which should help to identify exactly which invocation gets out of order, and also adds a sleep in the main shell loop to make it that much less likely that this race will occur.