Skip to content

docs: administration: monitoring: add backpressure_wait_seconds metric, fix duplicate row and style#2523

Merged
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_admin_monitoring_updates
Mar 24, 2026
Merged

docs: administration: monitoring: add backpressure_wait_seconds metric, fix duplicate row and style#2523
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_admin_monitoring_updates

Conversation

@eschabell
Copy link
Copy Markdown
Collaborator

@eschabell eschabell commented Mar 23, 2026

  • Add fluentbit_output_backpressure_wait_seconds histogram to v2 output metrics table (source commits 5ba94a9e0, fc8dbd45b)
  • Remove duplicate fluentbit_output_latency_seconds row from v2 table
  • Capitalize V1/V2 metrics headings to match sentence-style capitalization
  • Split two long sentences in the Chunk definition for both v1 and v2 sections

Summary by CodeRabbit

Documentation

  • Updated monitoring documentation with improved section formatting and clarified descriptions of chunk processing outcomes for better understanding of metric behavior and recovery actions
  • Introduced a new backpressure wait time metric for enhanced visibility into output performance monitoring
  • Removed a deprecated latency metric from the available metrics list

…c, fix duplicate row and style

  - Add fluentbit_output_backpressure_wait_seconds histogram to v2 output
    metrics table (source commits 5ba94a9e0, fc8dbd45b)
  - Remove duplicate fluentbit_output_latency_seconds row from v2 table
  - Capitalize V1/V2 metrics headings to match sentence-style capitalization
  - Split two long sentences in the Chunk definition for both v1 and v2 sections

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Mar 23, 2026
@eschabell eschabell requested a review from a team as a code owner March 23, 2026 15:23
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Mar 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 525d2d5d-ded2-439f-8d6a-3c9c0f03006e

📥 Commits

Reviewing files that changed from the base of the PR and between d1a3a63 and 4ba07de.

📒 Files selected for processing (1)
  • administration/monitoring.md

📝 Walkthrough

Walkthrough

This PR updates the monitoring documentation by standardizing section heading capitalization (v1/v2 metrics), clarifying chunk processing outcome descriptions, and adjusting the v2 Prometheus metrics list—removing fluentbit_output_latency_seconds and adding fluentbit_output_backpressure_wait_seconds.

Changes

Cohort / File(s) Summary
Documentation Updates
administration/monitoring.md
Standardized heading capitalization (lowercase to uppercase for v1/v2 metrics sections), refined descriptions of chunk processing outcomes, and updated v2 Prometheus metrics list by removing fluentbit_output_latency_seconds and adding fluentbit_output_backpressure_wait_seconds histogram.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 A metric takes flight as another takes rest,
Backpressure waits measured—we always know best!
Docs shine with capitals, clear as can be,
Chunk handling honest, from latency free. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main changes: adding a backpressure_wait_seconds metric, removing a duplicate row, and fixing style (capitalization).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell
Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@eschabell eschabell merged commit 25d55a1 into fluent:master Mar 24, 2026
8 checks passed
@eschabell eschabell deleted the erics_admin_monitoring_updates branch March 25, 2026 06:18
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants