Skip to content

docs: inputs: forward: clarify buffer_max_size payload enforcement#2524

Merged
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_in_forward_update
Mar 25, 2026
Merged

docs: inputs: forward: clarify buffer_max_size payload enforcement#2524
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_in_forward_update

Conversation

@eschabell
Copy link
Copy Markdown
Collaborator

@eschabell eschabell commented Mar 25, 2026

  • Updated buffer_max_size description to note that the limit applies to incoming payloads and decompressed data, and that connections sending oversized payloads are rejected and closed (reflects enforcement added in in_forward source commit 4ffc5b0a0)

Summary by CodeRabbit

  • Documentation
    • Updated configuration documentation to clarify that the maximum buffer size limit constrains incoming payloads and decompressed data. Payloads exceeding this limit are rejected and the connection is closed.

  - Updated `buffer_max_size` description to note that the limit
    applies to incoming payloads and decompressed data, and that
    connections sending oversized payloads are rejected and closed
    (reflects enforcement added in in_forward source commit 4ffc5b0a0)

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Mar 25, 2026
@eschabell eschabell requested a review from a team as a code owner March 25, 2026 06:55
@eschabell eschabell added the 5.0 label Mar 25, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86cec0ad-50e6-4507-b5ac-19dba9cbc7ca

📥 Commits

Reviewing files that changed from the base of the PR and between 5b017da and d987cb1.

📒 Files selected for processing (1)
  • pipeline/inputs/forward.md

📝 Walkthrough

Walkthrough

Documentation update to the Forward input plugin clarifying that buffer_max_size constrains incoming payloads and decompressed data, with payloads exceeding the limit being rejected and the connection closed.

Changes

Cohort / File(s) Summary
Documentation Update
pipeline/inputs/forward.md
Clarified buffer_max_size configuration description to explicitly state that it constrains incoming payloads and decompressed data, with rejection and connection closure for oversized payloads.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • alexakreizinger

Poem

🐰 Whiskers twitching, I clarify the way,
Buffer limits must have their say,
No oversized payload shall pass through,
The docs now shine with clearer view!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: clarifying documentation for buffer_max_size payload enforcement in the forward input plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Copy Markdown
Collaborator Author

Trivial text update to forward input plugin param description, merged based on ai review.

@eschabell eschabell merged commit c7214d5 into fluent:master Mar 25, 2026
8 checks passed
@eschabell eschabell deleted the erics_in_forward_update branch March 25, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant