Skip to content

tests: cumulative_to_delta: Enable cumulative test case on Windows #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cosmo0920 wants to merge 1 commit into from
Closed

tests: cumulative_to_delta: Enable cumulative test case on Windows #11597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/internal/cumulative_to_delta.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */

#include <math.h>
#include <unistd.h>

#include <cmetrics/cmetrics.h>
#include <cmetrics/cmt_counter.h>
Expand All @@ -12,6 +11,7 @@
#include <cmetrics/cmt_map.h>
#include <cmetrics/cmt_metric.h>
#include <cfl/cfl_kvlist.h>
#include <fluent-bit/flb_compat.h>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include flb_compat before cmetrics on Windows

On Windows this include is too late. tests/internal/cumulative_to_delta.c pulls in cmetrics/cmetrics.h first, and lib/cmetrics/include/cmetrics/cmetrics.h:45 -> cmt_compat.h:24-25 already includes <windows.h>. flb_compat.h then defines WIN32_LEAN_AND_MEAN and includes <winsock2.h>, which has to happen before <windows.h> to avoid the winsock.h/winsock2.h redefinition conflict. I checked tests/internal/CMakeLists.txt:117-123 and .github/workflows/call-windows-unit-tests.yaml:206-253; flb-it-cumulative_to_delta is built in the MSVC Windows unit-test job, so this patch still leaves the Windows build broken instead of enabling the test.

Useful? React with 👍 / 👎.


#include "../../plugins/processor_cumulative_to_delta/cumulative_to_delta.h"

Expand Down