Migrate CI to GitHub Actions and update to Go 1.23#89
Open
gundalow wants to merge 4 commits intofluffle:masterfrom
Open
Migrate CI to GitHub Actions and update to Go 1.23#89gundalow wants to merge 4 commits intofluffle:masterfrom
gundalow wants to merge 4 commits intofluffle:masterfrom
Conversation
Open
fluffle
requested changes
Mar 2, 2026
Owner
fluffle
left a comment
fluffle
left a comment
There was a problem hiding this comment.
Generally looks good.
Please can you take the time to squash and rebase this into a few logical commits. Ideally I'd like to see:
- removing .travis.yml, adding GHA, updating Dockerfile and go.mod
interface{}->anychanges- range loop changes
- everything else, i.e. ioutil deprecation, rand -> rand/v2, the comment formatting changes, etc
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.25' |
Collaborator
Author
There was a problem hiding this comment.
Sure, though my OS only has packages for go1.25.7, and I'd like to avoid having to manually build/upgrade go.
gundalow
force-pushed
the
migrate-to-gha-go1.23-6709935838327540399
branch
from
6a9e58c to
c68d5c5
Compare
Collaborator
Author
|
Good idea on logical commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the project's CI pipeline from Travis CI to GitHub Actions and upgrades the Go version to 1.23.
Key changes:
.travis.yml..github/workflows/ci.ymlwhich runs on push and pull requests tomaster. It performs agofmtcheck and runs unit tests with the race detector.go.modto specifygo 1.23.Dockerfileto usegolang:1.23for the build environment.gofmtto satisfy the new CI check.This change is