Skip to content

Delete launched wasmOptInSetting feature flag #9578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 2 commits into from
Dec 11, 2025
Merged

Delete launched wasmOptInSetting feature flag #9578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e3cd5
Delete launched wasmOptIn feature flag
elliette Dec 11, 2025
05b8323
Remove unused import
elliette Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions packages/devtools_app/lib/src/framework/scaffold/settings_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'package:provider/provider.dart';
import '../../shared/analytics/analytics_controller.dart';
import '../../shared/analytics/constants.dart' as gac;
import '../../shared/config_specific/copy_to_clipboard/copy_to_clipboard.dart';
import '../../shared/feature_flags.dart';
import '../../shared/globals.dart';
import '../../shared/log_storage.dart';
import '../../shared/server/server.dart';
Expand Down Expand Up @@ -77,23 +76,21 @@ class SettingsDialog extends StatelessWidget {
gaItem: gac.vmDeveloperMode,
),
),
if (FeatureFlags.wasmOptInSetting.isEnabled) ...[
const SizedBox(height: largeSpacing),
...dialogSubHeader(theme, 'Experimental features'),
Flexible(
child: CheckboxSetting(
title: '[Recommended] Enable WebAssembly',
description:
'This will trigger a reload of the page to load DevTools '
'compiled with WebAssembly. This may yield better '
'performance.',
notifier: preferences.wasmEnabled,
onChanged: preferences.toggleWasmEnabled,
gaScreen: gac.settingsDialog,
gaItem: gac.wasm,
),
const SizedBox(height: largeSpacing),
...dialogSubHeader(theme, 'Experimental features'),
Flexible(
child: CheckboxSetting(
title: '[Recommended] Enable WebAssembly',
description:
'This will trigger a reload of the page to load DevTools '
'compiled with WebAssembly. This may yield better '
'performance.',
notifier: preferences.wasmEnabled,
onChanged: preferences.toggleWasmEnabled,
gaScreen: gac.settingsDialog,
gaItem: gac.wasm,
),
],
),
const SizedBox(height: largeSpacing),
...dialogSubHeader(theme, 'Troubleshooting'),
const _VerboseLoggingSetting(),
Expand Down
9 changes: 0 additions & 9 deletions packages/devtools_app/lib/src/shared/feature_flags.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,6 @@ extension FeatureFlags on Never {
enabled: true,
);

/// Flag to enable the DevTools setting to opt-in to WASM.
///
/// https://github.com/flutter/devtools/issues/7856
static final wasmOptInSetting = BooleanFeatureFlag(
name: 'wasmOptInSetting',
enabled: true,
);

/// Flag to enable refactors in the Flutter Property Editor sidebar.
///
/// https://github.com/flutter/devtools/issues/9214
Expand Down Expand Up @@ -121,7 +113,6 @@ extension FeatureFlags on Never {
devToolsExtensions,
dapDebugging,
inspectorV2,
wasmOptInSetting,
propertyEditorRefactors,
};

Expand Down
5 changes: 1 addition & 4 deletions packages/devtools_app/lib/src/shared/preferences/preferences.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import '../analytics/constants.dart' as gac;
import '../config_specific/logger/logger_helpers.dart';
import '../constants.dart';
import '../diagnostics/inspector_service.dart';
import '../feature_flags.dart';
import '../globals.dart';
import '../primitives/query_parameters.dart';
import '../server/server.dart';
Expand Down Expand Up @@ -122,9 +121,7 @@ class PreferencesController extends DisposableController
// Get the current values and listen for and write back changes.
await _initDarkMode();
await _initAdvancedDeveloperMode();
if (FeatureFlags.wasmOptInSetting.isEnabled) {
await _initWasmEnabled();
}
await _initWasmEnabled();
await _initVerboseLogging();

await cpuProfiler.init();
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/test/shared/primitives/feature_flags_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ void main() {
expect(FeatureFlags.devToolsExtensions.isEnabled, isExternalBuild);
expect(FeatureFlags.dapDebugging.isEnabled, false);
expect(FeatureFlags.inspectorV2.isEnabled, true);
expect(FeatureFlags.wasmOptInSetting.isEnabled, true);
expect(FeatureFlags.propertyEditorRefactors.isEnabled, true);
});

Expand Down