-
Notifications
You must be signed in to change notification settings - Fork 392
Fix late initialization error in DevTools store logic #9816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
packages/devtools_shared/test/server/persistent_properties_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Copyright 2026 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. | ||
|
|
||
| import 'dart:convert'; | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:devtools_shared/src/server/file_system.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| group('IOPersistentProperties', () { | ||
| late Directory tempDir; | ||
| late IOPersistentProperties properties; | ||
| const storeName = 'test_store'; | ||
|
|
||
| setUp(() { | ||
| tempDir = Directory.systemTemp.createTempSync('persistent_properties_test'); | ||
| properties = IOPersistentProperties( | ||
| storeName, | ||
| documentDirPath: tempDir.path, | ||
| ); | ||
| }); | ||
|
|
||
| tearDown(() { | ||
| tempDir.deleteSync(recursive: true); | ||
| }); | ||
|
|
||
| test('remove persists changes to disk', () { | ||
| properties['key1'] = 'value1'; | ||
| properties['key2'] = 'value2'; | ||
|
|
||
| final file = File('${tempDir.path}/$storeName'); | ||
| expect(file.existsSync(), isTrue); | ||
|
|
||
| var content = file.readAsStringSync(); | ||
| var json = (jsonDecode(content) as Map).cast<String, Object>(); | ||
| expect(json['key1'], 'value1'); | ||
| expect(json['key2'], 'value2'); | ||
|
|
||
| properties.remove('key1'); | ||
|
|
||
| content = file.readAsStringSync(); | ||
| json = (jsonDecode(content) as Map).cast<String, Object>(); | ||
| expect(json.containsKey('key1'), isFalse); | ||
| expect(json['key2'], 'value2'); | ||
| }); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CONCERN] While moving this call fixes the late initialization error, the
_removeLegacyKeysmethod (and theIOPersistentProperties.removemethod it calls) does not currently persist changes to disk. This means legacy keys are only removed from memory and will reappear on the next run. Consider updating_removeLegacyKeysto useproperties[key] = nullor fixingIOPersistentProperties.removeto ensure the cleanup is permanent.References