Remove more legacy analytics logic#9817
Merged
kenzieschmoll merged 4 commits intoflutter:masterfrom May 4, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes legacy analytics functionality, including the isFirstRun property and associated API endpoints, from both devtools_app and devtools_shared. The changes involve deleting the isFirstRun key from the DevToolsStoreKeys enum, removing the reset and isFirstRun members from the DevToolsUsage class, and updating the server API handler. Feedback suggests adding a cleanup step in _removeLegacyKeys to ensure the isFirstRun key is removed from the user's persistent storage file to avoid stale data.
bkonyi
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow on to #9777 to remove a few additional legacy analytics APIs. Work towards #9819