Skip to content

fix: filter empty messages without altering text #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corvo-007 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: filter empty messages without altering text #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/genui/lib/src/transport/a2ui_transport_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class A2uiTransportAdapter implements Transport {
Stream<String> get incomingText => _pipeline
.where((e) => e is TextEvent)
.cast<TextEvent>()
.map((e) => e.text.trim())
.where((text) => text.isNotEmpty);
.map((e) => e.text)
.where((text) => text.trim().isNotEmpty);
Comment on lines +68 to +69

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using text.trim().isNotEmpty will discard chunks that consist entirely of whitespace, such as a single space (" ") or a newline ("\n"). In streaming LLM responses, it is extremely common for whitespace or newlines to be emitted as separate chunks. Discarding them will cause words to run together (e.g., producing "Helloworld" instead of "Hello world").

To preserve all valid whitespaces while filtering out truly empty strings, you should use text.isNotEmpty instead of text.trim().isNotEmpty.

Suggested change
.map((e) => e.text)
.where((text) => text.trim().isNotEmpty);
.map((e) => e.text)
.where((text) => text.isNotEmpty);


/// A stream of A2UI messages parsed from the input.
@override
Expand Down