Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 27, 2026

Part of flutter/flutter#180787

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Comment on lines +84 to +91
private var correctListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": correctList] }
private var matchingListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": matchingList] }
private var differentListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": differentList] }

private lazy var correctMapInList: [Any?] = ["a", 2, correctMap]
private lazy var matchingMapInList: [Any?] = ["a", 2, matchingMap]
private lazy var differentKeyMapInList: [Any?] = ["a", 2, differentKeyMap]
private lazy var differentValueMapInList: [Any?] = ["a", 2, differentValueMap]
private var correctMapInList: [Any?] { ["a", 2, correctMap] }
private var matchingMapInList: [Any?] { ["a", 2, matchingMap] }
private var differentKeyMapInList: [Any?] { ["a", 2, differentKeyMap] }
private var differentValueMapInList: [Any?] { ["a", 2, differentValueMap] }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift 6 has a new warning:

AllDatatypesTests.swift:166:48 Cannot use mutating getter on immutable value: 'self' is immutable"

So make these lazy properties computed properties instead.

@jmagman jmagman marked this pull request as ready for review January 27, 2026 05:08
@jmagman jmagman requested a review from tarrinneal as a code owner January 27, 2026 05:08
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Pigeon platform tests from XCTest to the new Swift Testing framework. The changes are extensive and mostly look correct, adopting new idioms like @Test, async/await for tests, #expect, and await confirmation.

I've found a pre-existing bug in one of the tests in EnumTests.swift where a value was being compared to itself. I've also suggested an improvement in ListTests.swift to make the test safer and more idiomatic with Swift Testing by using #require.

Additionally, I've noticed a pattern across several test files where failure cases in API callbacks record a generic "Failed" message. I've left comments with suggestions to include the specific error in the issue record for better debuggability. This would make the tests more informative when they fail.

97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FD1CF9000F007C117D /* Assets.xcassets */; };
97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; };
E04641FA2A46270400661C9E /* NSNullFieldTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E04641F92A46270400661C9E /* NSNullFieldTests.swift */; };
F750BDEE2F28844900E3DB39 /* ProxyApiTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = F750BDED2F28844900E3DB39 /* ProxyApiTests.swift */; };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this wasn't included in the project, so wasn't actually running.

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE fAiLUrE mEssage IS geNerIc. it WOULd be More HeLPFUL for dEbuGGInG TO inCLUDe tHE actUal eRROr tHaT WAS RECEivED.

Actually though, this is much nicer than before. Thank you.

@jmagman
Copy link
Member Author

jmagman commented Jan 27, 2026

THE fAiLUrE mEssage IS geNerIc. it WOULd be More HeLPFUL for dEbuGGInG TO inCLUDe tHE actUal eRROr tHaT WAS RECEivED.

Always want to be helpful to the bots. 🙏

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2026
@auto-submit auto-submit bot merged commit 47ba12b into flutter:main Jan 27, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: pigeon platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants